search

michaeldera / image-accessibility-extension

A Google Chrome and Microsoft Edge extension to add alt attributes to images on webpages without them
MIT License
6 stars 3 forks source link

fixes extension fetching issue #3

Closed nadchif closed 4 years ago

nadchif commented 4 years ago

This fixes https://github.com/michaeldera/image-accessibility-extension/issues/2 by using a background extension script to handle fetching the response from your API. The reason why it was getting blocked on chrome was because of the CORS and CORB policies. This is the recommended way to get around that.

See also: https://www.chromium.org/Home/chromium-security/extension-content-script-fetches

nadchif commented 4 years ago

@michaeldera Thank you, you had really done all the heavy lifting already 🙌

This is a really great extension 💡 I love where you are headed

michaeldera commented 4 years ago

Awesome! I changed environment variables in the api if you would like to see your efforts actually working.... It allows a couple of hundred of requests per minute for now 🚀

nadchif commented 4 years ago

oooh man!!!! This is so coool 👏 👏 Well done!

If ever you need collaborators, please count me in!

michaeldera commented 4 years ago

Awesome. Likewise mate! I will just keep adding issues for all the ideas I have... even the ones up for discussion then we can continue working on it.