search

michaeldera / image-accessibility-extension

A Google Chrome and Microsoft Edge extension to add alt attributes to images on webpages without them
MIT License
6 stars 3 forks source link

Add keys to limit access to the API #5

Open michaeldera opened 4 years ago

michaeldera commented 4 years ago

Is your feature request related to a problem? Please describe. At the moment the api is open but it will need to be closed if there is mass usage in case the endpoint to the api is used for purposes other than to support this extension. So the extension must have a key it uses to authenticate with the API to be granted access.

Describe the solution you'd like A key tied to the extension (preferred) or accounts for the users

Describe alternatives you've considered Rate-limiting from the API end.

nadchif commented 4 years ago

May I suggest both

  1. Require an account
    1. Apply rate-limiting to target fake or bot accounts

See also: https://developer.chrome.com/webstore/identify_user

michaeldera commented 4 years ago

Rate limiting would need to be implemented in the backend... So I will start work on that.

So for the accounts we just do the Google accounts or Also have the option for Microsoft Accounts (Considering that this will also be on Edge).... but naturally we would go for Google first?

nadchif commented 4 years ago

Agree, I Microsoft Accounts would also be very convenient for Edge users, but we can start off with the Google Accounts on Chrome

michaeldera commented 4 years ago

Agreed... We can start with Chrome.

michaeldera commented 4 years ago

@nadchif do you want to take this or should I work on it?

nadchif commented 4 years ago

I'd love to do it, but I may need to constantly communicate with you with regards the the backend side of this.

Some "real-time" method of communication would be convenient. Are you open to using slack?

michaeldera commented 4 years ago

Sure.. We can do that. The backend repo is also opn here. We can use Slack.