search

michaeldfallen / git-radar

A heads up display for git
MIT License
2.59k stars 85 forks source link

Provides a fix for Isssue #69. #77

Closed hallzy closed 9 years ago

michaeldfallen commented 9 years ago

Hi @hallzy, thanks for the contribution. Looks like this solves the issue of stat on OSX having a different interface than the one released by GNU.

There's one failing test which I'm looking at test_time_to_update_when_timestamp_is_old in test-directories.sh. If I get a fix I'll open a PR against this branch so you can merge it (since you own this fix) and then I'll merge this.

BTW, when opening a pull request it's useful to quickly describe why you've made these changes. The Issue holds that info but it tends to have more discussion.

michaeldfallen commented 9 years ago

@hallzy I've indentified the problem and fixed it. Changes are awaiting your merge in https://github.com/hallzy/git-radar/pull/1. Once you are happy and merge it in to your branch I'll merge this PR.

Closing for now. Reopen once you've merged https://github.com/hallzy/git-radar/pull/1.

Thanks

hallzy commented 9 years ago

It does not look like I can open this so a new PR #79 has been created.