michaeldmoore / michaeldmoore-multistat-panel

A smart table display panel with fixed, updating rows (or columns)
MIT License
57 stars 14 forks source link

Multistat stopped showing data after Grafana update to 9.2.4 version #70

Open tomekso opened 1 year ago

tomekso commented 1 year ago

After the update of Grafana the Multistat stopped working. No errors - just do not show graph. In a "table view" data are available.

michaeldmoore commented 1 year ago

Ok, I'll check it out.

On Tue, 7 Mar 2023 at 17:30, tomekso @.***> wrote:

After the update of Grafana the Multistat stopped working. No errors - just do not show graph. In a "table view" data are available.

— Reply to this email directly, view it on GitHub https://github.com/michaeldmoore/michaeldmoore-multistat-panel/issues/70, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4NLLREIGT4RRB55QEC56TW25PCPANCNFSM6AAAAAAVSWJLSE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

prashsaka commented 1 year ago

Thank you. By the way, this is the error that shows up in the console. And could be related.

image

benoitscherrer commented 1 year ago

Same here

SPKS-Berlin commented 1 year ago

Same here

michaeldmoore commented 1 year ago

The problem seems to be caused by a recent change in the D3 sort function. I'm testing a fix and should get a release out in a few days time. Thanks, everyone for reporting this.

On Mon, 20 Mar 2023 at 07:59, SPKS-Berlin @.***> wrote:

Same here

— Reply to this email directly, view it on GitHub https://github.com/michaeldmoore/michaeldmoore-multistat-panel/issues/70#issuecomment-1475714562, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4NLLTIT4EKWMMAJX6ZUDTW4754XANCNFSM6AAAAAAVSWJLSE . You are receiving this because you commented.Message ID: @.*** com>

benoitscherrer commented 1 year ago

Hi, There was a commit last month, with lots of code style updates, but also some actual code changes. Any chance this is fixed?

Thank you!

Pinkisagit commented 1 year ago

It seems like d3.nest() method needs to change to d3.group() method.

michaeldmoore commented 1 year ago

Exactly. I worked through the repercussions of this a while ago and committed the changes to the github repo. The current code fails some lint tests, so right now, it can't be set to an official releaseversion. I've been very busy with other life obligations, so I haven't gotten around to filing up whatever the lint issues were a situation that is likely to continue for some weeks still.

Right now, you can grab the latest commit from github and use that - it seems to work fine. You would have to configure Grafana to allow it as a non-signed plugin too. That should work with the latest Grafana release. Otherwise, hold off on the Grafana updates or find an alternative panel plugin.

Sorry for all the messing about and slow responses.

On Tue, 9 May 2023 at 09:49, Pinkisagit @.***> wrote:

It seems like d3.nest() method needs to change to d3.group() method.

— Reply to this email directly, view it on GitHub https://github.com/michaeldmoore/michaeldmoore-multistat-panel/issues/70#issuecomment-1539292336, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4NLLRIT5RWAYH3RHLF74LXFIAJLANCNFSM6AAAAAAVSWJLSE . You are receiving this because you commented.Message ID: @.*** com>

Pinkisagit commented 1 year ago

I've just copied your latest code and it works, thanks mate. Let's hope you can sort of your lint issues. Good luck.

prashanth-quantivly commented 1 year ago

Is the latest code right as it comments out the use of d3.nest?

So, I updated the code as below.

  // this.rows = d3
  //   .nest()
  //   .key(groupedLabelFunc)
  //   .rollup(function (d) {
  //     return d[0];
  //   })
  //   .entries(this.matchingRows)
  //   .forEach(function (x) {
  //     oo.push(x.value);
  //   });
  Array
    .from(d3.group(this.matchingRows, groupedLabelFunc))
    .map(d => {
      let key = d[0];
      let values = d[1];
      return { key: key, value: values[0] };
    })
    .forEach(x => oo.push(x.value));

Here is the untested updated file - https://gist.github.com/prashanth-quantivly/eacd7ea29b1b4501e263509cdaf6caca

michaeldmoore commented 1 year ago

Thanks Prashanth - your changes were very helpful. They didn't quite work for the max/min/sum and mean aggregations, but based on your code, I got them all working correctly.

The current version (v1.7.4) is checked in here and should work properly.

I'm fighting the release actions mechanism right now - this signs the plugin after running a set of validation steps. I don't understand why, but it seems grafana has changed - and broken - these github actions and I haven't figured out how to get it all working again. It might take a while before I can get the signing/validation actions working properly, so for the time bein, I can only offer this manual update process. I'm going to be out of the country for the next month, so I don't expect anything to happen for a while. Watch this space for updates...

atsetogl commented 1 year ago

Hello, could you guide me through the installation process of the v1.7.4 please? I am currently getting the plugin disabled because of missing signature.