michaeldoye / mat-progress-buttons

Very simple Angular6+ Material Design progress buttons
https://mat-progress-buttons.firebaseapp.com/
MIT License
110 stars 54 forks source link

Add mat-icon to the button #13

Closed medbejimbj closed 5 years ago

medbejimbj commented 6 years ago

Hello,

I'd like to add mat-icon to the button while the button is not submitted. is it possible ? Thanks

michaeldoye commented 5 years ago

Update: 7.1.2 includes icons for Fab buttons. Icons for normal buttons coming soon 👍

frabanca commented 5 years ago

Hi @michaeldoye , do you have an estimate delivery time for icons in normal buttons?

Maybe something like this:

const loadFromFileBtnOptions: MatProgressButtonOptions = {
    active: false,
    text: 'Load from File',
    spinnerSize: 19,
    raised: true,
    stroked: true,
    flat: false,
    fab: false,
    buttonColor: 'primary',
    spinnerColor: 'primary',
    fullWidth: false,
    disabled: false,
    mode: 'indeterminate',
    fontSet: 'fal', // For fontawesome "fas", "far", "fal", "fad" and "fab" while for standard angular icons "" (empty)
    icon: 'fa-user' // icon name
  };

An extra feature could be some extra options whitch will allow user to set a custom icon as a spinner. Font-Awesome has some nice ones.

Thanks and have a good day!

michaeldoye commented 5 years ago

@frabanca Full icon support for the normal buttons will be coming soon-ish. In the meantime, the fab-button now has full icon support (included in the next release)

frabanca commented 5 years ago

Yeah, I've used those icon type (they are awesome!) but I also need icons in normal buttons due to UI consistency. I will wait for the next release, maybe it will be before our project delivery :P :) Thanks again and have a good day!

michaeldoye commented 5 years ago

This feature will be included in the next release 🥇