Closed rynop closed 5 years ago
Thanks for the PR, have been super busy on my side so this is really helpful :) Will review and merge after work this evening.
Np. I'll add Fab button in here too this am. Will only take a minute and will allow u to kill 2 birds when you review.
Added fab button support.
I omitted fab
from Bar Button README cuz it looks janky:
If you don't want support for fab in bar, just LMK and I'll remove from bar-button.component.html
This is awesome, thanks dude!
Yeah, I think lets leave the fab out of the bar button and add a note in the readme to say that fab can only be used with spinner button... For now.
In a future release I want to add something like this demo (angular material 1): https://codepen.io/DevVersion/pen/vGebGB for the bar button
Ohh thats freaking slick! Man, now I want that!
I've removed fab from bar, added note to README.
I really like that spinner around the fab, I may make time to add that soon :)
Great, thanks!
Hahaha yeah it is quite nice indeed :)
Thanks again for the contributions, will merge your pr in a few hours.
Per https://github.com/michaeldoye/mat-progress-buttons/issues/16
Of note, I had to update your package.json because it used a version of event-stream (3.3.6) which had a HUGE vuln and was removed by NPM.
The large # of diffs on package.json are due to the fact that npm now alphabetizes dependencies.