michaeldoye / mat-progress-buttons

Very simple Angular6+ Material Design progress buttons
https://mat-progress-buttons.firebaseapp.com/
MIT License
110 stars 54 forks source link

Not compatible with Angular Material 9 #62

Closed ioannist closed 4 years ago

ioannist commented 4 years ago

Getting the error: ERROR in Cannot resolve type entity ɵngcc4.MatButtonModule to symbol

when using Angular Material ^9.0.0-rc.4

It's an easy fix... Components can no longer be imported through @angular/material. Use the individual secondary entry-points, such as @angular/material/button.

michaeldoye commented 4 years ago

Thanks for reporting. Will fix it for the next release

mrmokwa commented 4 years ago

Could we have at npm a next version like angular have? Angular 9 is around the corner with RC9 and it would be nice having it rolling before that.

luigi-13 commented 4 years ago

Hi, any news ?

michaeldoye commented 4 years ago

@zepekenio super busy at the moment, but should have some free time coming up to fix this.

newmesiss commented 4 years ago

from what I saw is just an import problem now it must be imported for each component used separately

gwenaellarmet commented 4 years ago

Hello since Angular 9 is out, is there any news on this issue ?

lucabrasi83 commented 4 years ago

Part of the fix I believe is to change the @angular/material imports and add a Type to ModuleWith Providers in module:

import {MatButtonModule} from '@angular/material/button'
import { MatProgressBarModule } from '@angular/material/progress-bar'
import {MatRippleModule} from '@angular/material/core';
import { MatIconModule } from '@angular/material/icon';
import {MatProgressSpinnerModule} from '@angular/material/progress-spinner';

export class MatProgressButtonsModule {
  static forRoot(): ModuleWithProviders<MatProgressButtonsModule> {
    return {
      ngModule: MatProgressButtonsModule
    };
  }
}
jochenonline commented 4 years ago

@lucabrasi83 Could you provide a PR to accelerate the process?

lujakob commented 4 years ago

@michaeldoye: I created a PR with the Angular 9 update. Would be happy if you could have a look as it's a blocker for several of my projects. Thanks :)

michaeldoye commented 4 years ago

Thank you to @lujakob! The new version is now available. Apologies for the delay, and thank you for the patience. <3