search

michaeldoye / mat-progress-buttons

Very simple Angular6+ Material Design progress buttons
https://mat-progress-buttons.firebaseapp.com/
MIT License
110 stars 54 forks source link

Migrate to Angular project type #73

Closed AndreyBespamyatnov closed 3 years ago

AndreyBespamyatnov commented 3 years ago

!Important: Please remove the private flag in projects\mat-progress-buttons\package.json file

I did some checks:

  1. The Demo app is working correctly and also been updated to Angular 11
  2. All test is working and Green
  3. I moved to Github Action, cause I do not have access to your pipeline system
  4. In the pipeline I have:
    • node 12.x and\or 14.x
    • build
    • tests
    • npm publish, you have to setup in your settings secrets the NPM token and setup the dry-run settings to false in the pipeline config file
    • publishing artifacts
  5. You need to create the Release manually, but I think we can setup another job for GitHub Action

Fixes #69 #72 #

michaeldoye commented 3 years ago

Looks good to me. I will merge it and add the NPM token and create a workflow for the release.

Appreciate the effort, if you ever find yourself in Amsterdam, I will buy you a beer 🍻

AndreyBespamyatnov commented 3 years ago

Looks good to me. I will merge it and add the NPM token and create a workflow for the release.

Appreciate the effort, if you ever find yourself in Amsterdam, I will buy you a beer 🍻

where you were last year )))) I'v been here the last Xmas)