search

michaelficarra / commonjs-everywhere

:rainbow: minimal CommonJS browser bundler with aliasing, extensibility, and source maps
BSD 3-Clause "New" or "Revised" License
158 stars 21 forks source link

makefile: prevent hypothetical double expansion #100

Closed davidchambers closed 10 years ago

davidchambers commented 10 years ago

Commit message:

Given the following makefile:

X = $(shell echo '$$HOME')

example:
    @echo 'single-quoted: $(X)'
    @echo "double-quoted: $(X)"

Running make will output something similar to the following:

single-quoted: $HOME
double-quoted: /Users/dc

Though double expansion will almost certainly never occur in practice, there's no downside to correctness in this case.

This project provides an excellent example of a makefile for a Node package. This is the reason I consider such trivial improvements worthwhile. :)

michaelficarra commented 10 years ago

I love these PRs. Keep them coming.