do something about all the duplication between sync/async versions - Githubissues

michaelficarra / commonjs-everywhere

:rainbow: minimal CommonJS browser bundler with aliasing, extensibility, and source maps

BSD 3-Clause "New" or "Revised" License

158 stars 21 forks source link

do something about all the duplication between sync/async versions #49

Closed michaelficarra closed 11 years ago

michaelficarra commented 11 years ago

Even if this forces the removal of the async versions. It's killing me.

vendethiel commented 11 years ago

I'm not sure why you added it in the first place ? It has worse perfs on my machine, does it improve it for you?

michaelficarra commented 11 years ago

Alright. If nobody says they actually use it by tomorrow, I'll drop it for 0.7. Bring the codebase back under 300 lines.

michaelficarra commented 11 years ago

Alright, consider the async interface a failed experiment.

michaelficarra commented 11 years ago

$ make loc
wc -l src/*
     145 src/command.coffee
     288 src/index.coffee
     433 total

:smile: reasonable again.

vendethiel commented 11 years ago

yep, that's really great (any reason you don't @ silence your makefile commands?)

michaelficarra commented 11 years ago

Send over a pull request.

vendethiel commented 11 years ago

Let me finish this one and I'll be all yours :).