search

michaelficarra / commonjs-everywhere

:rainbow: minimal CommonJS browser bundler with aliasing, extensibility, and source maps
BSD 3-Clause "New" or "Revised" License
158 stars 21 forks source link

makefile: remove release target #98

Closed davidchambers closed 10 years ago

davidchambers commented 10 years ago

The release target is unnecessary given the release-* targets, unless one wishes to bypass semver and specify NEXT_VERSION manually.

I'm not advocating this change, but it is worth considering. My motivation for considering this change for my own projects is to prevent a bad outcome should I accidentally run make release. This project has a confirmation prompt, though, so perhaps keeping the release target is fine.

michaelficarra commented 10 years ago

Well ideally somebody could do NEXT_VERSION=whatever make release as you suggest, but I've never used that, so I'm okay with this. Merging.