michaelgmcd / vscode-language-babel

VSCode syntax highlighting for today's JavaScript
https://marketplace.visualstudio.com/items?itemName=mgmcdermott.vscode-language-babel
MIT License
131 stars 17 forks source link

loses auto-indent #21

Closed rjohnep closed 6 years ago

rjohnep commented 6 years ago

VSCode Version: 1.21.1 Mac OS High Sierra 10.13.3

Open a JavaScript file Type

auto-indent is lost

26846989-52303ff0-4ab0-11e7-85fa-07af171051c1

swashata commented 6 years ago

I can also confirm this. I was trying on JSX files. I couldn't auto indent any components

<View>
|</View>

But without this extension

<View>
    |
</View>
michaelgmcd commented 6 years ago

VSCode supported this in https://github.com/Microsoft/vscode/commit/d12f86565089522a0bc65633d443c7fd3a04026d. It requires me to change the name of the syntax languages to be the same as theres. 'll push out a fix for this today.

swashata commented 6 years ago

Hello,

Has this been resolved? I see the commit got reverted...

michaelgmcd commented 6 years ago

Yes, I thought I had a fix, but turned out to cause some regressions. This is difficult because VSCode's support for this is tightly coupled to their own javascript syntax highlighting. I'm hoping to be able to support this sometime this week or weekend.

jaybyrrd commented 6 years ago

Hey, I just wanted to let you know this is driving me a bit crazy and I would appreciate a fix greatly. <3

kykungz commented 6 years ago

I'm moving from Atom and having this problem too. Does anyone have a workaround yet? or every vscode users are fine with this.

swashata commented 6 years ago

For now, I am just using the default vscode javascript (and javascript react) syntax. It works pretty good.

michaelgmcd commented 6 years ago

I'm still looking into solutions for this. Would love a PR!

michaelgmcd commented 6 years ago

This should be fixed in the latest release.