search

michaelgmcd / vscode-language-babel

VSCode syntax highlighting for today's JavaScript
https://marketplace.visualstudio.com/items?itemName=mgmcdermott.vscode-language-babel
MIT License
131 stars 17 forks source link

Highlighting broken in javascriptreact language based file #30

Closed madiodio closed 6 years ago

madiodio commented 6 years ago

I've just noticed that the latest release have broken the syntax highlighting of javascriptreact language based files potentially because of vscode-language-babel/commit/da7b1e2df5f8182814605b11098c32e220bc902d. Am I missing something as to why it was removed?

Thanks for the great work!

michaelgmcd commented 6 years ago

That was removed based on my research for https://github.com/michaelgmcd/vscode-language-babel/commit/74258cabed404843cfdd8097e037e64d1b08f392. What specifically is broken?

madiodio commented 6 years ago

My bad. But not just syntax highlighting is broken the whole grammar is broken eg. auto-completion specifically in template literals. see the diff below.

(Notice it works with Babel Javascript as the language identifier but does not in javascriptreact)

Babel Javascript

screen shot 2018-06-22 at 00 22 34

javascriptreact screen shot 2018-06-22 at 00 23 23

I checked the commit you refered to, but I still don't see why the javascriptreact language identifier was removed tough.

michaelgmcd commented 6 years ago

I'll revert that change. Thanks for looking into this!

michaelgmcd commented 6 years ago

@madiodio I've reverted it and published 0.0.17 with the change. Let me know if you continue to run into issues.

madiodio commented 6 years ago

Because of 74258ca we need to map the javascriptreactlanguage id. grammars to source.js to make it work properly, I've opened #31 for the fix.