michaelgmcd / vscode-language-babel

VSCode syntax highlighting for today's JavaScript
https://marketplace.visualstudio.com/items?itemName=mgmcdermott.vscode-language-babel
MIT License
131 stars 17 forks source link

Function calls with objects in template strings mismatching closing } #44

Open rattrayalex-stripe opened 5 years ago

rattrayalex-stripe commented 5 years ago

current behavior:

screen shot 2019-03-04 at 9 47 21 pm

github's behavior here is a bit better:

`hello ${world({
  one: 1,
  two: 2,
})} how are you`

specifically, the ${} characters should be a different color than the text, and the code inside should receive normal syntax highlighting.

I believe that the "Sublime Babel" vscode extension also has pretty good behavior here.

michaelgmcd commented 5 years ago

Hmm. This doesn't seem to be an issue on my machine. What theme are you using?

Screen Shot 2019-05-13 at 4 56 20 PM

rattrayalex-stripe commented 5 years ago

@michaelgmcd Looks like I'm on Dark+ (default dark) – is that supported? (Note that it has the same issue on Solarized dark)

michaelgmcd commented 5 years ago

Sorry for the delay. Can you try the "Palenight Italic" theme I'm using in the screenshot above?

rattrayalex-stripe commented 5 years ago

I do get the same result as you (it seems less broken), though it too is broken with the "Bracket Pair Colorizer" extension that I have:

Screen Shot 2019-06-05 at 2 58 04 PM

Note the closing }) which should be pink and then yellow

rattrayalex-stripe commented 5 years ago

@michaelgmcd any update here?