search

michaelgriscom / LeaderMode

A shortcut tree extension for Visual Studio Code with a build/test/publish pipeline through Travis
http://aka.ms/LeaderMode
MIT License
35 stars 0 forks source link

LeaderMode and Jumpy #26

Closed Davindawn closed 5 years ago

Davindawn commented 6 years ago

Just installed LeaderMode and I'm already in love with it. I love how it resembles which-key in spacemacs (would be awesome if it could eventually behave the same, opening a larger overlay and all). I just noticed however it conflicts with Jumpy.

LeaderMode works perfectly UNTIL Jumpy is used. After which LeaderMode will show that it's activated and the command suggestions are shown in the status bar, however, LeaderMode fails to register input of these commands and the input is simply typed out in the editor instead.

michaelgriscom commented 6 years ago

Thanks for the feedback! I agree it'd be great if which-key could be more fully emulated, hopefully the vscode UI extensibility model will be expanded to support that in the future

The bug you mentioned appears to be an issue in the jumpy code, which is exacerbated by a VSCode limitation (Microsoft/vscode#13441) I've opened wmaurer/vscode-jumpy#28 in the jumpy repo to track it

Akkuma commented 5 years ago

I know this is an old issue, but https://github.com/lucax88x/CodeAceJumper/ is actively being maintained and seems to work alright with LeaderMode @Davindawn

michaelgriscom commented 5 years ago

@Akkuma awesome, thanks for the heads up 😊 yep that extension is properly forwarding the type events. There hasn't been any action on Jumpy/my PR so I'll close this out