search

michaelgrund / GMT-plotting

Collection of GMT (Generic Mapping Tools) scripts, jupyter notebooks (using PyGMT) and files (including digitized map content, colormaps, grid files etc.)
99 stars 25 forks source link

009_paper_GR2020: Improve arguments passed to 'box' parameter #18

Closed yvonnefroehlich closed 4 months ago

yvonnefroehlich commented 7 months ago

This PR aims to improve the arguments passed to the box parameter of Figure.colorbar and Figure.legend. Please indicate if you prefer another appearance of the box fill or outline.

gitnotebook: https://gitnotebooks.com/michaelgrund/GMT-plotting/pull/18

smith-kyle commented 7 months ago

I noticed you all aren't using a notebook review tool and wanted to invite you to review this pull request with GitNotebooks: https://gitnotebooks.com/michaelgrund/GMT-plotting/pull/18

It lets you do things like comment on rendered markdown and code cells, so might be an easy win for your PR reviews.

yvonnefroehlich commented 7 months ago

I noticed you all aren't using a notebook review tool and wanted to invite you to review this pull request with GitNotebooks: https://gitnotebooks.com/michaelgrund/GMT-plotting/pull/18

It lets you do things like comment on rendered markdown and code cells, so might be an easy win for your PR reviews.

@smith-kyle thanks for pointing this out 🙂. It sounds interesting and useful. I will take a look at this in more detail.