Closed sam-crawley closed 1 year ago
This fixes #173
Thank you for doing this, @sam-crawley ! Including tests was a wonderful touch. Just wondering if the function also still works with old-style output?
I've added a test with an output generated from an older Mplus version.
Thank you very much @sam-crawley!
Indeed, thanks for this update, @sam-crawley! And thanks to @cjvanlissa for merging it into the codebase. I just reviewed the code as well and it looks great to me. Next time I roll out a CRAN update, I'll put this code through my internal checks, which has TECH10 outputs going back to Mplus 5. But I appreciate your adding formal tests for the update, which is definitely the direction things should go.
Cheers, Michael
An additional line was added, so updated the parsing to account for this, and added a test.
The first commit is a simple fix for the bug, the second reworks TECH10 parsing completely, and also extracts the new value in newer versions of Mplus.