search

michaelhelmick / django-balancer

A set of tools for using Django's multi-db feature.
BSD 3-Clause "New" or "Revised" License
110 stars 5 forks source link

RoundRobinRouter shuffles self.pool, which is a setting. #7

Closed jdunck closed 12 years ago

jdunck commented 13 years ago

It seems that mutating a global (setting) is asking for trouble. Perhaps BasePoolRouter should copy the thing that it assigns to self.pool.

https://github.com/bkonkle/django-balancer/blob/develop/balancer/routers.py#L81

bkonkle commented 13 years ago

Very good point! I'll fix it this week.

Thanks!

bkonkle commented 12 years ago

About 6 months later than expected, but corrected. Thanks!