michaelherger / lms-plugin-tidal

A TIDAL plugin to integrate with the Lyrion Music Server (fka. Logitech Media Server)
41 stars 7 forks source link

add More menu and OnTidal favorites #61

Closed philippe44 closed 3 months ago

philippe44 commented 3 months ago

This PR is a port of what I did on Deezer to handle the M(ore) menu for tracks, albums, artists and playlists, including adding them as a Tidal favorite. I've left the podcast-related code although I'm not sure there is podcast on Tidal or if you plan to support that.

I hope this helps and I wanted to do that before you start doing your own so that we can align and maybe share a broader framework for this "More/Favorites management plugin" issue.

michaelherger commented 3 months ago

Splitting up code is definitely the way to go. I'd probably have called it InfoMenu, rather than just Info. In some cases I called it OPML... because that's what we'd return from them. But it's a bit technical. We could even have Plugins::TIDAL::Menu::Info, Plugins::TIDAL::Menu::Browse etc., if we wanted to have a clean structure.

philippe44 commented 3 months ago

I'm also adding the possibility to add playing track or any track to any given user-modifiable playlist so I'll see if that can be adapted for Tidal.

michaelherger commented 3 months ago

Thanks!