search

michaelherger / lms-plugin-tidal

A TIDAL plugin to integrate with the Lyrion Music Server (fka. Logitech Media Server)
43 stars 8 forks source link

Are we sure of that? #65

Closed philippe44 closed 6 months ago

philippe44 commented 6 months ago

https://github.com/michaelherger/lms-plugin-tidal/blob/307b77b9cc640429032caebb8ded7285c51a1475/API.pm#L173

michaelherger commented 6 months ago

What aspect do you have doubts about?

philippe44 commented 6 months ago

The ttl, can it be time() + 90 days?

michaelherger commented 6 months ago

Yeah, that's an oddity of the caching module...

https://github.com/LMS-Community/slimserver/blob/2360483fdb321b06c425225b2a8ec6592b22dde0/Slim/Utils/DbCache.pm#L190-L191

        # "If value is less than 60*60*24*30 (30 days), time is assumed to be
        # relative from the present. If larger, it's considered an absolute Unix time."
michaelherger commented 6 months ago

It could be rewritten as '3M'. Would be simpler.

philippe44 commented 6 months ago

So if I write '90days', I'm good then?

michaelherger commented 6 months ago

Yes, or that.