search

michaelherold / benchmark-memory

Memory profiling benchmark style, for Ruby 2.1+
MIT License
217 stars 6 forks source link

Added Support for Linux on Power #20

Closed ujjwalsh closed 3 years ago

ujjwalsh commented 3 years ago

Hi, I had added ppc64le(Linux on Power) support on travis-ci in the branch and looks like its been successfully added. I believe it is ready for the final review and merge. The travis ci build logs can be verified from the link below. https://travis-ci.com/github/ujjwalsh/benchmark-memory/builds/207319675 Please have a look.

Regards, ujjwal

michaelherold commented 3 years ago

Thanks for the contribution! We have switched to GitHub Actions so this PR doesn't make sense any longer.

Unless there is a reason that the Power architecture was failing, I don't think adding additional stress to the CI solution, regardless of what it is, makes a lot of sense. If you were seeing failures that you then fixed (or asked us to fix), then I would be happy to accept a change for that.