search

michaelherold / benchmark-memory

Memory profiling benchmark style, for Ruby 2.1+
MIT License
217 stars 6 forks source link

Need to require StringIO #4

Closed rzane closed 7 years ago

rzane commented 7 years ago

This fixes

benchmark-memory-0.1.1/lib/benchmark/memory/job/io_output/entry_formatter.rb:26:in `to_s': uninitialized constant Benchmark::Memory::Job::IOOutput::EntryFormatter::StringIO (NameError)
michaelherold commented 7 years ago

Thanks for the contribution!

Can you describe how you're using the library to get this error? Ruby version? Example file? I haven't ever seen this be a problem, but it could be something that I'm implicitly relying on.

It looks like there's some cleanup that I have to do with the build process, but once I do that I'll look at this again.

rzane commented 7 years ago

Looks like the following only works on 2.3+

$ ruby -e 'StringIO.new'
michaelherold commented 7 years ago

Closed via 710e801.

Thanks for the contribution!