search

michaelhly / solana-py

Solana Python SDK
https://michaelhly.github.io/solana-py
MIT License
978 stars 252 forks source link

SPL Name Service #225

Open michaelhly opened 2 years ago

michaelhly commented 2 years ago

The bulk of the work has already been done here: https://github.com/Auguron/solana-py/blob/8b8516aedb158c5b0a5d5b742043c4e1507452ef/src/name_service/name_program.py

Let's write some tests and we can merge the code from the fork.

crypt0miester commented 2 years ago

added and made the tests as well. but the tests fail with

'Transaction simulation failed: Attempt to load a program that does not exist'

added memo program as well, all tests went through.

crypt0miester commented 2 years ago

for reference: https://github.com/crypt0miester/solana-py/tree/add-ns-memo

michaelhly commented 2 years ago

@crypt0miester thanks! I'll go create an issue to ask them to include some common SPL programs inside the docker image.

michaelhly commented 2 years ago

@crypt0miester I think the Memo program should be included? Do you think you can split support for memo vs name service in separate PRs?

crypt0miester commented 2 years ago

@crypt0miester I think the Memo program should be included? Do you think you can split support for memo vs name service in separate PRs?

sure, I'm afk now. will do it as soon as I can.

crypt0miester commented 2 years ago

looks like one of the PR's that updated the solana version fixed the issue of memo not being in the localnet.

tests are going through.

I will be adding PR shortly.