search

michaelhly / solana-py

Solana Python SDK
https://michaelhly.github.io/solana-py
MIT License
979 stars 252 forks source link

Remove transaction module #442

Open kevinheavey opened 2 months ago

kevinheavey commented 2 months ago

The transaaction module is broken (see #268) and solders.transaction works so I guess we should just use that?

This also entails changing the send_transaction methods such that it is the caller's job to fetch a recent blockhash and sign the transaction

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 92.17877% with 14 lines in your changes missing coverage. Please review.

Project coverage is 89.89%. Comparing base (7f2f3cb) to head (37b4b75).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #442 +/- ## ========================================== + Coverage 89.77% 89.89% +0.12% ========================================== Files 28 27 -1 Lines 2210 2118 -92 ========================================== - Hits 1984 1904 -80 + Misses 226 214 -12 ```
michaelhly commented 1 month ago

Perhaps we should add a migration guide to the documentation? https://github.com/michaelhly/solana-py/blob/master/docs/core/transaction.md

michaelhly commented 1 month ago

@kevinheavey Actually. I think it'd be better to emit a depreciation warning to notify users to use the solder's transaction rather than outright deletion.