search

michaelhly / solana-py

Solana Python SDK
https://michaelhly.github.io/solana-py
MIT License
1.04k stars 273 forks source link

Deprecate transaction module #442

Closed kevinheavey closed 3 weeks ago

kevinheavey commented 4 months ago

The transaaction module is broken (see #268) and solders.transaction works so I guess we should just use that?

This also entails changing the send_transaction methods such that it is the caller's job to fetch a recent blockhash and sign the transaction

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 91.57895% with 16 lines in your changes missing coverage. Please review.

Project coverage is 89.03%. Comparing base (0a57fd9) to head (858b9d8). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #442 +/- ## ========================================== - Coverage 89.58% 89.03% -0.55% ========================================== Files 28 28 Lines 2227 2280 +53 ========================================== + Hits 1995 2030 +35 - Misses 232 250 +18 ```
michaelhly commented 3 months ago

Perhaps we should add a migration guide to the documentation? https://github.com/michaelhly/solana-py/blob/master/docs/core/transaction.md

michaelhly commented 3 months ago

@kevinheavey Actually. I think it'd be better to emit a depreciation warning to notify users to use the solder's transaction rather than outright deletion.

neochine commented 1 month ago

Could you please fix this issue https://github.com/michaelhly/solana-py/issues/453, then merge it using pull request and then remove from solana.transaction import Transaction so I can use older version of solana-py even if its removed. Thanks