Assessment Results

[kaitvan]

Hi Michael, I finished reviewing your assessment and there are some changes that I’d like for you to make before we consider you technical ready. Please have them done by EOD Monday and send me a slack message once completed!

JUST FYI -- no need to make these changes. This feedback is only for your learning.

• In your variables.rb file, you don't need parenthesis around num_3 + num_9 for your sum variable. It still works the way it is, but you would only need parenthesis to specify the order of operations.
• On line 8 of your variables.rb file, you used the .shift method, but you don't need the parenthesis to remove only the first element in the array! You use the parenthesis to pass in how many elements you want to remove. Without the parenthesis, the method defaults to removing only one item.
• Be careful with the names for your boolean variables in model_a.rb and model_b.rb. For example, in model_b.rb, you have two variables with boolean values car_of_the_year and good_gas_mileage-- these are unclear if they should have a numerical value or a boolean value. You could make it better by changing the variable names to something like is_car_of_the_year and has_good_gas_mileage.

MUST BE CHANGED

• [x] Your model_a.rb and model_b.rb files should be inside of a models directory. The directions say, "Inside of mod_0_assessment, create a new directory called models." Please add a models directory and move those two files into that directory.

Send me a DM on Slack when you've completed these changes! Thank you.

[michaeljhicks]

Thank you for the carefully detailed feedback! Really good point on how to appropriately name boolean variables and I'll implement that moving forward.

[kaitvan]

Thanks for getting to these changes quickly! I know they seem like small things, but I would love for you to have really solid syntax habits from Mod 0, so that you can focus on concepts in Mod 1. I now feel confident that you have a solid understanding of Ruby syntax, data types, and how to model data using hashes. You are officially technical ready. Keep up the hard work moving forward and let me know if you have any questions. As mentioned on the Mod 0 site, we will be reviewing your Mod 1 Prework to determine promotion to Mod 1 - finish strong!