search

michaeljolley / awesum.io

awesum.io is a platform built to recognize those who have helped others in some way.
https://awesum.io
MIT License
3 stars 4 forks source link

Identify recipient on gramercy, (hopefully) addresses #34 #35

Closed Windos closed 4 years ago

Windos commented 4 years ago

I'm a little rusty around my C#, but I'm hoping this is good for addressing issue #34.

This adds the recipientHandle property, changes the existing twitterUrl to a more specific senderTwitterUrl so as to not be confused with the new recipientTwitterUrl.

Lines 7 and 9 are longer than I'd like, I wasn't sure what options are available for breaking those lines inside a Vue template.

I could build this locally, and it succeeded, but I couldn't actually test that the functionality works. All going well, the attribution under the message should now look something like:

— @WindosNZ for @MichaelJolley

Windos commented 4 years ago

It is my first Vue project, but the guts of it are so similar to HTML/XML and the like so as to not get overwhelmed!

Thanks for the guidance and the awesum (ha!) initiative.

michaeljolley commented 4 years ago

bitmoji

@allcontributors please add @Windos for code

allcontributors[bot] commented 4 years ago

@MichaelJolley

I've put up a pull request to add @Windos! :tada: