michaelklishin / quartz-mongodb

A MongoDB-based store for the Quartz scheduler. This fork strives to be as feature complete as possible. Originally by MuleSoft.
Other
248 stars 203 forks source link

Revert deprecation of MongoDBJobStore.overrideMongo #105

Closed BenRomberg closed 8 years ago

BenRomberg commented 8 years ago

We've implemented a way to override the Mongo Client with #77. I wonder why this is marked as deprecated now? Is there another way to override the Mongo Client in a test environment?

michaelklishin commented 8 years ago

@BenRomberg see https://github.com/michaelklishin/quartz-mongodb/commit/9fee3bb43bb1a8e92c09791432a0e0ca1d33b02a.

BenRomberg commented 8 years ago

Thanks. So I guess the proposed strategy is to extend MongoDBJobStore and provide the Mongo instance within the call to the super-constructor, and use that class as the org.quartz.jobStore.class.

michaelklishin commented 8 years ago

To use the newly introduced constructor any way you need, correct.