search

michaelklishin / quartz-mongodb

A MongoDB-based store for the Quartz scheduler. This fork strives to be as feature complete as possible. Originally by MuleSoft.
Other
248 stars 203 forks source link

Make Job Data serialization to base64 optional. #120

Closed dorogush closed 8 years ago

dorogush commented 8 years ago

Storing Job Data as a base64 should be optional (but default). Other option is to store directly as embedded document (if only simple types are used).

dorogush commented 8 years ago

@michaelklishin @pwojnowski please review.

michaelklishin commented 8 years ago

Please add some test cases.

dorogush commented 8 years ago

Done

pwojnowski commented 8 years ago

To me it looks ok.

pwojnowski commented 8 years ago

Thank you! :+1:

dorogush commented 8 years ago

Is it possible to publish to public repo? I plan to use it in production and I need this and #103

michaelklishin commented 8 years ago

@dorogush we will do our best to release another preview of 2.0 this week.

dorogush commented 8 years ago

@michaelklishin thanks!

dorogush commented 8 years ago

@michaelklishin Any update on release?

michaelklishin commented 8 years ago

I tried publishing to oss.sonatype.org only to be reminded that it's such a shit show. I need to wait for a JIRA ticket to be resolved before can do anything and then hope my reading of the docs for Nexus deployment was correct.

michaelklishin commented 8 years ago

Alternatively I can investigate releasing to Bintray. We will see which way ends up being more straightforward. Ultimately both can promote to Maven Central.

michaelklishin commented 8 years ago

@dorogush can you please give https://bintray.com/michaelklishin/maven/quartz-mongodb/2.0.0-rc3 a try?

dorogush commented 8 years ago

Maven Central is indeed a bit harder to bootstrap. You need to configure your build tool to also generate javadoc and source jars, artifacts should be signed with gnupg. Also, if you want to fully automate the process, you need to configure nexus plugin for the build tool, so the artifact will be automatically promoted from sonatype repo to maven central. Anyway, I'm glad you you published to bintray. Artifact is now available:

<repositories>
    <repository>
        <id>michaelklishin</id>
        <url>https://dl.bintray.com/michaelklishin/maven/</url>
    </repository>
</repositories>
<dependency>
    <groupId>com.novemberain</groupId>
    <artifactId>quartz-mongodb</artifactId>
    <version>2.0.0-rc3</version>
</dependency>

In addition i believe you can easily promote your artifacts to jcenter, so the url will be http://jcenter.bintray.com/