search

michaelklishin / quartz-mongodb

A MongoDB-based store for the Quartz scheduler. This fork strives to be as feature complete as possible. Originally by MuleSoft.
Other
248 stars 203 forks source link

Don't require Clojure dependency #129

Closed efge closed 6 years ago

efge commented 7 years ago

Would you consider a patch to make Clojure an optional dependency? It's probably required in the original authors' use cases, but for most of us it's an additional unneeded 3.7 MB JAR.

I'm thinking of making DynamicClassLoadHelper test the presence of clojure.lang.DynamicClassLoader by reflection, and if not present just delegate to the standard CascadingClassLoadHelper.

michaelklishin commented 6 years ago

DynamicMongoDBJobStore can be moved to Quartzite.

michaelklishin commented 6 years ago

I evaluated moving DynamicMongoDBJobStore to Quartzite. Arguably it fits here and for reasons that are not very interesting, it is easier to make Clojure an optional dependency here than in Leiningen (but retain the ability for it to compile Java sources).

Clojure already was a provided dependency, I switched to a compile only one.