michaelklishin / quartz-mongodb

A MongoDB-based store for the Quartz scheduler. This fork strives to be as feature complete as possible. Originally by MuleSoft.
Other
249 stars 203 forks source link

Set ERROR state for trigger without existing job. #138

Closed gmiejski closed 7 years ago

michaelklishin commented 7 years ago

@pwojnowski WDYT?

gmiejski commented 7 years ago

Sorry, forgot to include this:

Similar to what we can see here: https://github.com/quartz-scheduler/quartz/blob/5cc9a44ab96ad5a3591d9d77472ff6620d85456c/quartz-core/src/main/java/org/quartz/impl/jdbcjobstore/JobStoreSupport.java#L2822

Plus added extra logging, because people can not be aware of such situations.

michaelklishin commented 7 years ago

@gmiejski thanks.

michaelklishin commented 7 years ago

@pwojnowski thank you for the review.

michaelklishin commented 7 years ago

@pwojnowski is this good to go now?

pwojnowski commented 7 years ago

It looks good to me. Thank you! :+1: