search

michaelklishin / quartz-mongodb

A MongoDB-based store for the Quartz scheduler. This fork strives to be as feature complete as possible. Originally by MuleSoft.
Other
249 stars 203 forks source link

Declare keys in comound indexes in group then name order. Also fix use o... #49

Closed lordbuddha closed 10 years ago

michaelklishin commented 10 years ago

There appears to be a typo that fails compilation. Please correct it and push to the same branch (the PR will be updated and re-tested automatically).

michaelklishin commented 10 years ago

And, thank you!

lordbuddha commented 10 years ago

That missing semicolon I think is on your branch master not mine....

michaelklishin commented 10 years ago

I still see tests failures even after correcting that. Need to investigate if this may be stale DB state somewhere:

org.quartz.SchedulerConfigException: Error while initializing the indexes
 at com.novemberain.quartz.mongodb.MongoDBJobStore.ensureIndexes (MongoDBJobStore.java:975)
    com.novemberain.quartz.mongodb.MongoDBJobStore.initialize (MongoDBJobStore.java:78)
    com.novemberain.quartz_mongodb.test.units_test$make_store.invoke (units_test.clj:37)
    com.novemberain.quartz_mongodb.test.units_test/fn (units_test.clj:432)
…
Caused by: com.mongodb.CommandFailureException: { "serverUsed" : "/127.0.0.1:27017" , "ok" : 0.0 , "errmsg" : "index not found"}
 at com.mongodb.CommandResult.getException (CommandResult.java:71)
    com.mongodb.CommandResult.throwOnError (CommandResult.java:110)
    com.mongodb.DBCollection.dropIndexes (DBCollection.java:847)
    com.mongodb.DBCollection.dropIndex (DBCollection.java:1349)
    com.novemberain.quartz.mongodb.MongoDBJobStore.ensureIndexes (MongoDBJobStore.java:971)
    com.novemberain.quartz.mongodb.MongoDBJobStore.initialize (MongoDBJobStore.java:78)
lordbuddha commented 10 years ago

I did not get that. Ahhh, perhaps the second time it is run when the old index has already been removed.

Give me a mo, will wrap in a try catch.

lordbuddha commented 10 years ago

Fixed by #50.