JobExecutionContext.getPreviousFireTime returns actual execution time

[daniel-h]

When getting the previous fire time in a Job implementation via JobExecutionContext.getPreviousFireTime() it actually returns the current time of execution.

It seems the previousFireTime is set to early in the process.

I would assume it should be set after the job has been completed, when the lock is removed, taking the time from the lock entry as previousFireTime?

Best regards, Daniel

[michaelklishin]

Feel free to submit a pull request if you think you understand what the problem is and what's the right way to solve it :) Thank you!

[daniel-h]

After some debugging it seems the issue is as follows:

In method MongoDBJobStore.triggersFired()

The code is updating the trigger (and thus trigger times) trigger.triggered(cal); storeTrigger(trigger, true);

before passing the trigger values to the TriggerFiredBundle which in turn provide it in the JobExecutionContext.

The fix is to move the two lines of code to the end of the for-loop so it reads:

results.add(new TriggerFiredResult(bndle)); // Now update the trigger trigger.triggered(cal); storeTrigger(trigger, true);

I have tested it successfully, but please review and confirm the fix, since I don't know all the details of Quartz

Best regards, Daniel

[michaelklishin]

@ifesdjeen: please take a look

[daniel-h]

Submitted pull request now. Hope I did it right, was the first time :-)

[ifesdjeen]

Checked out PR, looked @ JobStoreSupport code.

        Date prevFireTime = trigger.getPreviousFireTime();

        // call triggered - to update the trigger's next-fire-time state...
        trigger.triggered(cal);

I would say I see the correlation, too...

[qtxo]

I was bitten by this problem in 2.1.0, tldr DON'T use trigger.getPreviousFireTime() use: JobExecutionContext.getPreviousFireTime()