search

michaelklishin / quartz-mongodb

A MongoDB-based store for the Quartz scheduler. This fork strives to be as feature complete as possible. Originally by MuleSoft.
Other
248 stars 203 forks source link

Cut and push a new release #87

Closed michaelklishin closed 9 years ago

jochenberger commented 9 years ago

Any news on this one? I'd love to see a release that includes #85, #86. and #89.

michaelklishin commented 9 years ago

Need to wait for some more changes from @pwojnowski and then we can release 2.0.

pwojnowski commented 9 years ago

Shall this release still support Java 6? Got answer: MongoCollection implements AutoCloseable that was introduced in Java 7.

michaelklishin commented 9 years ago

@pwojnowski no, now is a good time to drop JDK 6 support.

pwojnowski commented 9 years ago

Just one more question. In QueryHelper.matchingKeysConditionFor() "case ENDS_WITH" doesn't have "break" and falls through to "case CONTAINS". Was that on purpose?

michaelklishin commented 9 years ago

@pwojnowski no, definitely not. I suspect this came unnoticed because "endsWith" is the least frequently used matcher :)

pwojnowski commented 9 years ago

That's all from my side at this moment. IMHO you can do the release and other changes (if any) will go into the next (possibly minor/bugfix) release.

michaelklishin commented 9 years ago

@pwojnowski thank you, will do!

michaelklishin commented 9 years ago

I'm going to cut a new release in the next couple of days. Sorry for the delay.

slawomirsepiol commented 9 years ago

Hi. I found bug in the current code - every method that is supposed to pause or resume multiple triggers, actually changes state of only one. I fixed that and submitted a pull request - could you include it in the release?

michaelklishin commented 9 years ago

@slawomirsepiol sure, thank you!

michaelklishin commented 9 years ago

There were quite a few changes so I decided to release 2.0.0-rc1 first. Please give it a try.