search

michaelklishin / welle

An expressive Clojure client for Riak with batteries included
http://clojureriak.info
92 stars 26 forks source link

Add support to accept a port for hosts of PB Cluster Client [Issue #16] #17

Closed kirankulkarni closed 11 years ago

kirankulkarni commented 11 years ago

While creating a Protocol Buffer Cluster Client you can now provide hosts in format <host>:<port> e.g. "127.0.0.1:10017". If port is not provided default port will be Used.

So now you can use following format:

(wc/connect-to-cluster-via-pb! ["10.0.1.2",
                                "10.0.1.3",
                                "10.0.1.4",
                                "10.0.1.5",
                                "10.0.1.6"])

as well as following format:

(wc/connect-to-cluster-via-pb! ["127.0.0.1:10017",
                                "127.0.0.1:10027",
                                "127.0.0.1:10037",
                                "127.0.0.1:10047",])
michaelklishin commented 11 years ago

What about non-cluster PB client?

kirankulkarni commented 11 years ago

I think to create a non-cluster client you use connect-via-pb! which already has a port argument. This Pull request solves Issue #16 that I had reported.

michaelklishin commented 11 years ago

Note that master is Welle 2.0 which has breaking API changes.

You may want to port this to 1.5.x-stable (cherry-picking should work just fine) so that I can cut a release you'd be able to use immediately.

kirankulkarni commented 11 years ago

I am submitting a new pull-request for that