search

michaelkotelnikov / rhacm-workshop

Red Hat Advanced Cluster Management training and workshop exercises
45 stars 94 forks source link

Fix tiny warning in multicluster observability #6

Closed mbaldessari closed 2 years ago

mbaldessari commented 2 years ago

Got this warning while going through the workshop:

$ oc apply -f https://raw.githubusercontent.com/michaelkotelnikov/rhacm-workshop/master/03.Observability/exercise/multiclusterobservability.yaml -n open-cluster-management-ob servability W0325 21:03:50.356740 117051 warnings.go:70] observability.open-cluster-management.io/v1beta1 MultiClusterObservability is deprecated in v2.3+, unavailable in v2.6+; use observability.open-cluster-management.io/v1beta2 MultiClusterObservability W0325 21:03:50.501598 117051 warnings.go:70] observability.open-cluster-management.io/v1beta1 MultiClusterObservability is deprecated in v2.3+, unavailable in v2.6+; use observability.open-cluster-management.io/v1beta2 MultiClusterObservability multiclusterobservability.observability.open-cluster-management.io/observability created

Moving this yaml to observability.open-cluster-management.io/v1beta2 since it is deprecated in 2.3+

mbaldessari commented 2 years ago

Argh, of course I tested it from the wrong branch. Apologies for that. I changed it now and retested it on OCP 4.9 + ACM 2.4.2 (I suppose ACM 2.3 will be fine with it but I did not test it)

michaelkotelnikov commented 2 years ago

Looks good now :)