search

michaelkourlas / voipms-sms-client

Popular Android messaging app for VoIP.ms, a Canadian VoIP provider
https://play.google.com/store/apps/details?id=net.kourlas.voipms_sms
Apache License 2.0
218 stars 52 forks source link

Conversation List Item phone number #122

Closed adamzk closed 7 years ago

adamzk commented 7 years ago

Its always set to the user's number. Shouldn't it be the number of the relevant contact? Or perhaps to the number of the most recent message's author?

michaelkourlas commented 7 years ago

That's by design. It's meant to be used to indicate the DID associated with a conversation, which is useful when you are using multiple DIDs.

michaelkourlas commented 7 years ago

With that said, maybe the DID should be hidden if you only have one configured.

Rolnaz commented 7 years ago

Great idea Michael

michaelkourlas commented 7 years ago

Fixed in 0.5.3.

adamzk commented 7 years ago

That was fast. You're awesome.

On Jun 16, 2017 5:43 PM, "Michael Kourlas" notifications@github.com wrote:

Closed #122 https://github.com/michaelkourlas/voipms-sms-client/issues/122 .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/michaelkourlas/voipms-sms-client/issues/122#event-1127667991, or mute the thread https://github.com/notifications/unsubscribe-auth/ALMTBABwHo4XCsU9sZLJmxrNaClLnfghks5sExMPgaJpZM4N4zZg .