search

michaelkourlas / voipms-sms-client

Popular Android messaging app for VoIP.ms, a Canadian VoIP provider
https://play.google.com/store/apps/details?id=net.kourlas.voipms_sms
Apache License 2.0
218 stars 52 forks source link

Investigate maximum message length issues #186

Closed michaelkourlas closed 4 years ago

michaelkourlas commented 5 years ago

This is a VoIP.ms bug.

The VoIP.ms API is treating the characters ' and " (at least -- there might be others) as taking two characters instead of one.

I've opened a ticket with them. Others might want to do so as well.

cdrage commented 5 years ago

Hey @michaelkourlas I'm assuming this is related to the recentsms_too_long errors?

julianlam commented 5 years ago

Is it an issue with their (VoIP.ms's) end? Should we bug them incessantly for updates? :laughing:

michaelkourlas commented 5 years ago

This is a VoIP.ms bug.

The VoIP.ms API is treating the characters ' and " (at least -- there might be others) as taking two characters instead of one.

To reproduce, send the following message via the API, and them via http://sms.voip.ms. It will fail in the former case and succeed in the latter case.

This is a test SMS message that uses the ' character and which is exactly 160 characters long. aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa

michaelkourlas commented 5 years ago

I've opened a ticket with them. Others might want to do so as well.

julianlam commented 5 years ago

Will do, thanks for the explanation!

michaelkourlas commented 5 years ago

The latest from VoIP.ms:

Hello Michael,

This is still being looked into.

We apologize for the delay.

Regards.

__ John Loria VoIP.ms Customer Service

noryb009 commented 5 years ago

Until the bug is fixed upstream, does it make sense for this app to also count ' and " incorrectly?

michaelkourlas commented 5 years ago

I'm hoping they'll fix it first. I'd rather not implement the workaround and then have to remove it later.

michaelkourlas commented 4 years ago

Looks like they fixed this.

Whateverman2012 commented 4 years ago

Just experienced it... I use french. Maybe a 'special' characters issue.