michaelkourlas / voipms-sms-client

Popular Android messaging app for VoIP.ms, a Canadian VoIP provider
https://play.google.com/store/apps/details?id=net.kourlas.voipms_sms
Apache License 2.0
218 stars 52 forks source link

Dark mode does not persist after app close #206

Closed hdlineage closed 4 years ago

hdlineage commented 4 years ago

I'm using LG V30 on android 9. Dark mode works the first time i toggle the option, however after closing the app completely, the app went back to light mode. I have to toggle the option again to get it back to dark mode.

michaelkourlas commented 4 years ago

Unfortunately, device specific issues like this are basically impossible for me to debug.

If you can explain what the problem is and suggest a fix, please feel free to reopen.

smnc commented 4 years ago

I actually have this issue as well, on two different devices: my Acer Chromebook Tab10, and my Samsung Galaxy Note 8.0; so it's not a device specific issue.

I manually set the app to use the "Dark" theme, and it works. But every time I close and re-open the app, while the setting itself persists, but the the actual theming doesn't. Changing the setting to "Light" and then back to "Dark" works, but every time I close and re-open the app, it defaults back to light.

smnc commented 4 years ago

GT-N5120(Galaxy Note 8.0) Screenshot_20200613-120922 Chomebook Tab10 Screenshot 2020-06-13 at 12 16 33

michaelkourlas commented 4 years ago

Okay, that's interesting. I'll investigate this further.

smnc commented 4 years ago

I've got an update on this issue. My N5120 is running a custom Android 7.1 ROM without native support for system-wide dark mode. I've recently started using the "Dark Mode" app, by Julian Eggers, which seems to trick many apps in to thinking the system-wide dark mode is enabled. Since doing this, VOIP.ms SMS has persiststantly stayed in dark mode.

Screenshot_20200627-163939 Screenshot_20200627-164259 Screenshot_20200627-164220 Screenshot_20200627-164243

I tried the same thing on my Chromebook Tab 10 with the same result.

smnc commented 4 years ago

Thanks!