search

michaelkourlas / voipms-sms-client

Popular Android messaging app for VoIP.ms, a Canadian VoIP provider
https://play.google.com/store/apps/details?id=net.kourlas.voipms_sms
Apache License 2.0
216 stars 51 forks source link

Long SMS > 160 bytes are not concatenated #230

Closed kaechele closed 3 years ago

kaechele commented 3 years ago

Maybe a follow-up to #69, however when sending a long SMS through the voip.ms Webinterface it is correctly concatenated.

I used the following 400 byte text snippet for testing:

Lorem ipsum dolor sit amet, consectetur adipiscing elit. Curabitur dolor velit, tempus a consectetur eu, mollis sed sapien. Curabitur eget dolor mi. Proin faucibus, tellus quis mattis aliquam, dui erat tincidunt nunc, vel malesuada odio nunc non ante. Phasellus convallis, mi in malesuada lacinia, ipsum diam egestas nulla, at pretium enim ante at eros. Suspendisse mollis magna erat, imperdiet eros.

View from within the voip.ms SMS app

View from within the voip.ms SMS app

Result from App on Android SMS

Result from App on Android SMS app

View from voip.ms Webinterface

The last message sent was composed from within the webinterface. View from voip.ms Webinterface

Result from Webinterface on Android SMS

Result from Webinterface on Android SMS

kaechele commented 3 years ago

This is the form data that is being sent from the webinterface when sending a long SMS:

{
    "method": "send_message",
    "contact": "416xxxxxxx",
    "did": "647478xxxx",
    "typemsg": "MMS",
    "msg": "Lorem+ipsum+dolor+sit+amet,+consectetur+adipiscing+elit.+Curabitur+dolor+velit,+tempus+a+consectetur+eu,+mollis+sed+sapien.+Curabitur+eget+dolor+mi.+Proin+faucibus,+tellus+quis+mattis+aliquam,+dui+erat+tincidunt+nunc,+vel+malesuada+odio+nunc+non+ante.+Phasellus+convallis,+mi+in+malesuada+lacinia,+ipsum+diam+egestas+nulla,+at+pretium+enim+ante+at+eros.+Suspendisse+mollis+magna+erat,+imperdiet+eros.",
    "media1": "",
    "media1type": "",
    "media1realtype": "",
    "media2": "",
    "media2type": "",
    "media2realtype": "",
    "media3": "",
    "media3type": "",
    "media3realtype": ""
}

Note how typemsg is MMS.

For comparison a message that is exactly 160 bytes:

{
    "method": "send_message",
    "contact": "416xxxxxxx",
    "did": "647478xxx",
    "typemsg": "SMS",
    "msg": "Lorem+ipsum+dolor+sit+amet,+consectetur+adipiscing+elit.+Proin+leo+ante,+aliquet+sed+viverra+eu,+tristique+non+orci.+Proin+neque+dui,+hendrerit+nec+massa+proin.",
    "media1": "",
    "media1type": "",
    "media1realtype": "",
    "media2": "",
    "media2type": "",
    "media2realtype": "",
    "media3": "",
    "media3type": "",
    "media3realtype": ""
}

Here typemsg is SMS.

kaechele commented 3 years ago

To send MMS from the API the sendMMS endpoint must be used. So this is related to #190.

michaelkourlas commented 3 years ago

Correct, this is a duplicate of #190.