search

michaelkourlas / voipms-sms-client

Popular Android messaging app for VoIP.ms, a Canadian VoIP provider
https://play.google.com/store/apps/details?id=net.kourlas.voipms_sms
Apache License 2.0
216 stars 51 forks source link

Update API endpoints to remove www prefix #263

Closed purpleidea closed 6 months ago

purpleidea commented 6 months ago

On or about 25/Jan/2024, voip.ms changed their server config to remove the www prefix from their API. This broke all the clients that included that. This updates the prefix. voip.ms denied breaking things, but it seems it was the case after all.

purpleidea commented 6 months ago

Note, I don't have the build infra to test this, but based on user reports, this should be a sensible fix.

michaelkourlas commented 6 months ago

I don't typically accept PRs (see https://github.com/michaelkourlas/voipms-sms-client/blob/master/CONTRIBUTING.md) but thanks anyways!

purpleidea commented 6 months ago

Looks like you just copied my patch and committed it as your own?

https://github.com/michaelkourlas/voipms-sms-client/commit/5c5a6ee9c10d7e7a3caeaa95bfa17081e26c2f60

Not that it's a complicated patch to either write or review, but kind of a strange sort of way to respond.

michaelkourlas commented 6 months ago

Replacing "www.voip.ms" with "voip.ms" at each of the httpPostWithMultipartFormData call sites is trivial, and I did so without reference to your patch.

Open source projects can be run in many different ways. Many are open to unsolicited contributions, but this one is not. This is clearly stated in the policy I linked to. In future, please follow the policy and ask before submitting a PR.