michaelkubina
commented
3 years ago Hi and thanks for the PR. The updated README.md for the assembly guide is usefull indeed.
The holes in the servohorn being to tight was something i was unaware of. I appreciate pointing it out to me and providing a solution. The problem i see here is that your freecad-file is faulty - the document tree is wrong/defective, like there are unused planes, pads and pockets outside of the part->body structure and defective references to external geometry in the sketches. Freecad can be tricky sometimes and it took my a while to make good files as well. But in the current state this is nothing i can pull with a good mind to repo. BUT The holes you are speaking of (i have looked into it), are at 1,5mm, which is really too small. The minimum should be at least at 1,6mm as a core-hole, which then gets auto-threated by screwing the M2 in as its in the metric ISO standard. In all other parts i went with 1,9 ...so i will adapt this really quick and push to repo immideatly. So again, thanks for pointing this out to me.
I also appreciate the idea of a mountingplate, that allows for an Arduino (Uno, Mega?). I would pull it to repo with good mind only if it went to the mods-section within the parts folder. You can place a subfolder there, add a readme and update the mods-overview README.md with your description (https://github.com/michaelkubina/SpotMicroESP32/tree/master/parts/SpotMicroESP32_parts_v1_0_0/mods) of the mod.
The reason why i expect it to be in the mods-section is beause of several reasons:
- the most important is, that since this build is originally all about the esp32 it would result in false expectations that the arduino is supported in any way by me. I already see the questions coming up for the wiring diagram, or how to lower the voltage or where the screwholes are for the other modules/lipo/charger etc. used in the esp32-build and how they could be used or if i could adapt the plate and so on... and i cant support this kind of questions, as its too timeconsuming and conflicts with my goals for this project.
- This is why it should not appear at the top level of the parts section, but rather within the mods-section with unofficial mods, where you could describe in detail how it works or reference to your repo, where all software/electronic magic is happening. Maybe you want to provide additional files that are usefull for your mod as well, so with this folder you could easily do. (I am also planning a little rearrangement and pulling the deprecated parts out of there in a deprecated folder to streamline it a bit).
- also you should look into your FreeCAD files here again as the share the same issues as the servohorn...defective document tree, many unused planes and padding/pockets and other operations, that actually dont do anything.
So to make your mountingplate explicitly distuingishable from the main build, i encourage you to put them in a custom mods-folder in the mods section as your personal realm and to maybe look again at the freecad files if you can improve quality. The STLs as exported right now are good btw - no need for changes here - , but if others would like to make changes to your mod then it would be tricky with your freecad files.
AugustDG
Finished (I think) adding links and changing names (in the assembly instructions) to the appropriate places and corresponding names in the parts list!
Also added a mounting plate to use with an Arduino and the PCA 9685 (no LiPo support holes though)!
Finally, modified servohorn holes to make them bigger as it was almost impossible to fit M2 screws in the previous holes 😅