search

michaellperry / Assisticant

MIT License
36 stars 19 forks source link

ObservableDictionary does not implement non-generic IDictionary interface. #36

Closed russell-elledge closed 2 years ago

russell-elledge commented 3 years ago

Assisticant's ObservableCollection<> class has base classes that support both System.Collections.Generic.ILIst and System.Collections.ILIst.

Assisticant's ObservableDictionary does not implement both System.Collections.Generic.IDictionary and System.Collections.IDictionary. Only the former generic form is implemented.

This prevents ObservableDictionary from being passed to a utility method as an untyped System.Collections.IDictionary. Instead, methods must know the fully typed signature of the incoming ObservableDictionary or IDictionary<TKey, TValue>.

michaellperry commented 3 years ago

Good call out. Would you be interested in creating a PR on that? Sounds like a good patch.

russell-elledge commented 3 years ago

...pull request submitted.

michaellperry commented 2 years ago

PR merged