search

michaellperry / Assisticant

MIT License
36 stars 19 forks source link

Implement IReadOnlyList/IReadOnlyDictionary on collections #39

Closed qwertie closed 2 years ago

qwertie commented 2 years ago

I was surprised to see that these interfaces aren't implemented. Assisticant is incompatible with my app architecture without them.

Note: I don't have Android/iOS/Portable project types installed and so couldn't verify that the changes are fully nonbreaking.

BTW there is a Assisticant.Netstandard project but I didn't see it on NuGet. Have you considered adding it to NuGet or switching to .NET Standard 2.0/2.1?

qwertie commented 2 years ago

And by the way... is it normal for a Computed to have a reference to itself in Uses? I think that's what I'm seeing...

image

michaellperry commented 2 years ago

The attempt to support netstandard failed. I think the best way forward now is to just skip to .NET Core. That is going to become a priority for me as Jinaga.NET matures.

In the meantime, I think we can get the build working with the System.Runtime package. Let me see what I can do.

As for the dictionary depending upon itself, I would expect the circular reference detection to catch that. I'm not sure what I'm seeing there.

michaellperry commented 2 years ago

I misremembered about netstandard. In fact the fix appears to be to switch away from PCL and use the netstandard build. Making progress.

michaellperry commented 2 years ago

Merged and deployed. Thank you, as always.