Closed robertvazan closed 9 years ago
I implemented this as ViewSelector not too long ago. But I did not implement the markup extension. Could you change the markup extension to use the existing class?
Whoops, sorry, I should have looked for existing implementation first. Now that you have put it in the main Assisticant namespace, it would make sense to put both markup extensions in the same namespace as well, so that people don't have to declare multiple Assisticant namespaces in XAML. What do you think?
I think Assisticant is overusing namespaces in general. There's no point in isolating Observable<> and ObservableList<> in separate namespaces. I think the public API (everything except internal/platform wrappers and stuff) should be in one namespace.
While I agree that the markup extension should be in the Assisticant namespace for practical reasons, historically I would have put everything UI-centric in Assisticant.XAML. The core namespace was for concepts that were independent of the layer.
That's also the historical reason for Fields and Collections. These things are not core to dependency tracking. They are conveniences for the model layer.
So, yes, go ahead and put the markup extension in Assisticant, but I think Observable
I've amended the pull request. It should be fine now.