michaellukashov / Far-NetBox

SFTP/SCP/FTP/FTPS/WebDAV/S3 client for Far Manager 3 (http://farmanager.com/)
https://forum.farmanager.com/viewtopic.php?t=6317
GNU General Public License v2.0
161 stars 52 forks source link

Crash after server reboot #186

Open evgenybf opened 8 years ago

evgenybf commented 8 years ago

NetBox version: 2.1.45 build 420

Log in via ssh (sftps, disabled fallback to SCP) using a private key in .ppk format. Start editing a text file on the server. In another window reboot the server. During the rebooting try to save the the file to the server. It fails as the server is not reachable and is trying to reconnect. Ok...

 Searching for host...                      ¦

The server has been rebooted and NetBox realizes that connection's been lost.

 Server unexpectedly closed network connection.  
 Copying files to remote side failed.            

After ok it rises the access violation

 Exception:   Access violation (read from 0x0000000000000020)      
 Address:     0x00007FFA8DD593A9                                    
 Function:    ProcessEditorEventW                                   
 Module:      \Program Files\Far Manager\Plugins\NetBox\NetBox.dll  
VictorVG commented 8 years ago

The idea is all right - you have one window external application edits the file on the server, in another something else without looking at it, and restarts the event editor falls after taking a run his program writing in her memory garbage.

If everything is as you describe, then the bug was not there, but there is an unfortunate situation, but yes, from a user perspective to fall is not good.

P.S.

And about the screenshots:

error message would be easier to just copy as text - that it is important:

Exception: Access violation (read from 0x0000000000000020) Address: 0x00007FFA8DD593A9 Function: ProcessEditorEventW Module: \ Program Files \ Far Manager \ Plugins \ NetBox \ NetBox.dll

and all the rest simply text messages to and specify the version as v2.1.45.420 - all her stuffing we know, and you just inexperience did extra work for yoursel

evgenybf commented 8 years ago

If everything is as you describe, then the bug was not there, but there is an unfortunate situation, but yes, from a user perspective to fall is not good.

Actually, it happens even when the connection is getting lost (server shutdown, vpn disconnect and so on) and the user is not able to save the edited text somewhere else as FAR crashes right after the reconnection's failed.

Re-P.S. Ok, but I don't see any difference between copying the text inside of the frame and copying it together with the frame - the latter just needs a little broader mouse movement.

michaellukashov commented 8 years ago

Please try new version 2.2.0, you can download it on releases page https://github.com/michaellukashov/Far-NetBox/releases Far3 version can be found in nightly Far3 builds http://www.farmanager.com/download.php

evgenybf commented 8 years ago

@michaellukashov, Far 3.0 build 4550 x86

Now it's much more difficult to crash it down but still possible. I open a file on the server, modify it, close down the vpn connection to the network with the ssh server, save the file, NetBox is trying to connect, somewhere in between (count to 10) I open the connection back, receive the message that connection to the ssh server timed out, and after reconnect sometimes the plug-in falls with the exception.

 Exception:   Access violation (read from 0x0070006D)
 Address:     0x5C3F656B
 Function:    ProcessEditorEventW
 Module:      am Files (x86)\Far Manager\Plugins\NetBox\NetBox.dll

Stack:

 0: 00C2E156  - 0x8358966596739268608
 1: 00C2E4FA  - 0x8358966596739268608
 2: 775BFE27 RtlLoadString - 0x2002517008
 3: 775C4166 RtlUnwind - 0x2002534320
 4: 775D8E9F KiUserExceptionDispatcher - 0x2002620048
 5: 03888EC8 KiUserExceptionDispatcher - 0x2002620048