michaellukashov / Far-NetBox

SFTP/SCP/FTP/FTPS/WebDAV/S3 client for Far Manager 3 (http://farmanager.com/)
https://forum.farmanager.com/viewtopic.php?t=6317
GNU General Public License v2.0
155 stars 52 forks source link

Fix hotkey problems #453

Closed ssvine closed 2 months ago

ssvine commented 2 months ago

This pull request fixes many problems regarding hotkeys. Summary of the fixed problems:

  1. Many hotkeys processed by the plugin are ambiguous due to inconsistent checks. For example, Ctrl-G (Apply command) can also be processed as Ctrl-Alt-G or Ctrl-Shift-G.
  2. Insert full file name action (bound to Ctrl-F hotkey) inserts full file name as a "session url" like ssh://user@localhost:22/tmp/abc.txt which is not actually the full file name. Several issues were created to argue with such a behaviour. This pull request provides a better alternative - release Ctrl-F hotkey and bind the action to Ctrl-Alt-F.
  3. Aforementioned insert full file name action inserts empty prefixes for all protocols except scp / sftp.
  4. A hotkey Ctrl-; (Ctrl-Alt-;) shows incorrect results and may lead to a crash.
  5. NetBox binds two hotkeys to one action (Ctrl-Alt-Ins, Alt-Shift-Ins) not allowing Far to provide a different alternative action. It's better to keep only one hotkey (Alt-Shift-Ins), thereby allowing users to use both actions.
  6. Unable to show command menu (Alt-Shift-W) when editing a file.
  7. Edit history selects the wrong file (multiedit mode is on).
  8. Synchronize checklist misses Alt modifier in Alt-Right hotkey (horizontal scrolling), also horizontal scrolling is not working.

Pos. 2 mention this issues: 1 and 2

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud