Fix Charset encoding for filenames

michaellukashov / Far-NetBox

SFTP/SCP/FTP/FTPS/WebDAV/S3 client for Far Manager 3 (http://farmanager.com/)

https://forum.farmanager.com/viewtopic.php?t=6317

GNU General Public License v2.0

155 stars 52 forks source link

Fix Charset encoding for filenames #466

Closed ssvine closed 2 months ago

ssvine commented 2 months ago

Charset encoding for filenames on Environment tab of Session edit dialog is not working. You cannot actually change charset of filenames. This happend because TSessionData::DoCopyData does not copy FCodePage / FCodePageAsNumber fields.

This PR fixes aforementioned issue. It should also help solve this external issue.

Under the hood, this PR also removes duplicate code fragment that remained after routine update.

sonarcloud[bot] commented 2 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud