search

michaellukashov / Far-NetBox

SFTP/SCP/FTP/FTPS/WebDAV/S3 client for Far Manager 3 (http://farmanager.com/)
https://forum.farmanager.com/viewtopic.php?t=6317
GNU General Public License v2.0
155 stars 52 forks source link

Fix situations where some exception messages are not displayed #473

Closed ssvine closed 1 month ago

ssvine commented 1 month ago

Some error messages are not shown. For example, when connecting to FTP with non-existent domain name nothing is shown, while other types of sessions show error message. In debug builds one can see an assertion: Expression: ExceptionMessageFormatted(E, ExMessage) || !AQuery.IsEmpty().

The root cause: EFatal constructor forgot copying messages of external exception.

After fixing this problem, other problems were found:

  1. Error messages may be duplicated.
  2. Clicking Abort in the reconnect dialog shows redundant message that connection failed.
  3. Reconnecting to an inacessible FTP leads to a crash.
  4. In some cases the plugin panel is not closed when the connection is lost.

This PR fixes this problems.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud