search

michaellukashov / Far-NetBox

SFTP/SCP/FTP/FTPS/WebDAV/S3 client for Far Manager 3 (http://farmanager.com/)
https://forum.farmanager.com/viewtopic.php?t=6317
GNU General Public License v2.0
155 stars 52 forks source link

Fix several problems in session info dialog #474

Closed ssvine closed 1 month ago

ssvine commented 1 month ago

Here is the screenshot of the session info dialog:

si-before

There are several problems here:

  1. Info names have strange prefixes (like 23-Compression). There is no alignment of keys and values.
  2. Text may extend beyond the dialog borders.
  3. In most cases keys and values are separated by :, while some others are not.
  4. There are no server certificate fingerprints for encrypted SSL connection.

In addition, there is a problem with TFarLister (Capabilities tab => Additional protocol information section): text disappears (or freezes, or plugin crashes) when scrolled with mouse wheel.

This PR fixes the aforementioned issues. When fixing problem 4, UI was unified to show 2 fingerprints: SHA1 and SHA256 for SSL/TLS connections, MD5 and SHA256 for SCP/SFTP connections:

si-after

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint