search

michaellunzer / Home-Assistant-Custom-Component-Fortnite

This is a Home-Assistant custom component that pulls Fortnite stats using the python API library from the site fortnitetracker.com
https://github.com/michaellunzer/Home-Assistant-Custom-Component-Fortnite
MIT License
4 stars 3 forks source link

Fixing Actions #13

Closed ikifar2012 closed 3 years ago

ikifar2012 commented 3 years ago

I noticed that the action still was not working after you merged the PR even though it was working for me, I found that this was due to the ha-blueprint action which the template repo that this has been created from is not using

Purposed Change

In this PR I have removed the ha-blueprint action and replaced it with the tests found in the integration_blueprint repo

ikifar2012 commented 3 years ago

Interesting that the pytest fails but all else is ok

ikifar2012 commented 3 years ago

Sorry if this is spamming you, I just had some issues getting it working, it turned out the issue was a typo where the dir was using a . instead of a /

ikifar2012 commented 3 years ago

The tests were failing due to code coverage from pytest, which I have now removed. If you want coverage reports, I recommend you setup something like codecov which they have on the main HA core repo, from what I can see its way better than anything you can get using a GitHub action